-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FAKKU plugin has stopped working #983
Comments
@pandafeliz I submitted a pull request to fix this. But here is the raw file you can use to patch your version so you don't have to wait on the next release. |
Automatic mode is still broken but this fixed manual mode which is good enough for me, thanks. |
Hmmm. I will do more testing to see why. |
@pandafeliz Found the issue and patched it. |
That did the trick, thanks for the fix. EDIT: Actually, whatever changes they did to the site rendered the automatic mode useless, out of 100 archives it miss-tagged 97% of them and I had to double check the three that it got correctly. |
Was/still is how the plugin is written to do. It just gets the file name, cleans it up, and searches it, and gets the first result. For the ":in this month." tag. It looks like FAKKU has that with the other tags in the HTML code of the webpage. The quick and dirty fix is to add it to your tag blacklist. But that's not really a good fix for it. I will see if I can update it exclude that. |
Made a fix for the ":in this month." tag. It seems to be a rare edge case with it will only showing up if the doujin is in the top 10 of two categories. It will not show up if it is only in the top 10 of one category. The fix is kinda dirty. It just checks the tag, and if it is equal to ":in this month." it just skips it. I don't really know a better way to solve this. (I'm guessing a way to test to see if the div that contains the "in this month." text is there and not to check it. But again I don't know the best way/how to do that.) For now the plugin works great in manual mode, it just about works in auto mode (depending on the name of the file and if searching for it makes it the first result). I still only recommend that it be used in manual mode. And as always @pandafeliz if you run into other issues or find any problems let me know and I will do my best to fix it. |
Thanks for the fixes, like I said, I also use mostly manual mode but back before they modified the site and broke the automatic mode the first time it wasn't that bad at grabbing around 70% correctly, at least on my case. I don't think they have an API, that's why the plugin relies on grabbing the tags from the html page, but I could be wrong. |
Automatic mode can work but it's never been accurate since it just does a search manually and picks the first result.. There's not really much else we can do for it imo |
LRR Version and OS
LRR 0.9.0
Windows 11
Bug Details
The metadata plugin for FAKKU has stopped working, both in automatic and manual mode. The automatic mode stopped working a few months back but the manual mode was still fine until a few days ago, I suspect is because they made some modifications to the website.
I know the plugin has been kinda wonky since the beginning and the suggested method was to use the chaika plugin, but they have stopped uploading any FAKKU related content for more than a year so is not really an option anymore.
Matching Logs
Log attached because of character limit
fakkupluginlog.txt
Screenshots
The text was updated successfully, but these errors were encountered: