RFC: i18n for accounts-base

[softwarerero]

The accounts-base package unfortunately does not throw error codes but english texts in case of an error. This is not directly accounts-entry's problem but we could work around it. There are a few calls to Session.set('entryError', error.reason) which could be replaced by Session.set('entryError', (i18n err.reason.replace ".", "") || err.reason) and a translation could be provided like "Email already exists": "Email ya existe".

Do you think it makes sence to have this in accounts-entry? Should a provide a pull request for this?

[queso]

I am not opposed to it, but would it be cleaner to have the errors thrown properly from base? I don't think the MDG would oppose such a request for internationalization reasons.

[queso]

I am also inclined to accept #78 before we solve this issue... The functionality gain outweighs the internationalization issues, imo.

[softwarerero]

I could do the translations for #78. I have no idea if I could fix it in the pull request or if I should wait until you have merged it.

[softwarerero]

You are right that it would be cleaner to change accounts-base directly. I will open a ticket over there and we'll see how they respond.

[queso]

K. Happy to throw in on that, I love that we have such strong internationalization on this package :)

[softwarerero]

MDG wants to deal with this post-1.0. I personally do not want to wait that long. Instead of the call above Session.set('entryError', (i18n err.reason.replace ".", "") || err.reason) we could call a helper function Session.set 'entryError', translate err.reason, so the day the MDG packages have translations we could just change that method to return its only parameter. That's the least intrusive way I could think of. To pull or not to pull then?

[queso]

Ok, I can get behind that idea.

[softwarerero]

I have added it to the open pull requests. In the future I have to find out how to assign unrelated commits to different pull requests.

[queso]

This is related to PR #86

[queso]

Merged #86.