Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backsearch P1]Use standard auth like on the lx backend #8

Open
King-Mob opened this issue Nov 9, 2023 · 1 comment
Open

[Backsearch P1]Use standard auth like on the lx backend #8

King-Mob opened this issue Nov 9, 2023 · 1 comment

Comments

@King-Mob
Copy link
Collaborator

King-Mob commented Nov 9, 2023

Can still use the single secret system, but copy the webtoken method from lx-back-end so that every request doesn't have if(!secret || secret != process.env.SECRET) in it

@lin-d-hop lin-d-hop changed the title Use standard auth like on the lx backend [Backsearch P1]Use standard auth like on the lx backend Nov 30, 2023
@rogup
Copy link
Contributor

rogup commented Jan 9, 2024

@lin-d-hop What's you reason for making this a P1?
IMO this is very minor and can wait, since it doesn't make any difference to users (it isn't a security concern) and not much difference to us as developers, since the service only has 2 routes anyway. The change isn't trivial and using webtokens actually complicates things a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants