Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update edit page #536

Closed
RubenFricke opened this issue Jun 25, 2021 · 3 comments · Fixed by #580
Closed

Update edit page #536

RubenFricke opened this issue Jun 25, 2021 · 3 comments · Fixed by #580
Assignees
@elislaats
Labels
priority Only assign this label if it's asked to assign this label

Comments

@RubenFricke
Copy link
Member

Is your feature request related to a problem? Please describe.
The edit page feels out of place in the current implementation. Update the edit page for projects.

Describe the solution you'd like
Update the edit page. We've been talking about processing the edit page in the modal, just like the project details page.

Production URL
https://www.figma.com/file/GTR0nlTW57coac7vIYXWkO/Platform-current-version?node-id=0%3A1

Additional context
Our first iteration that could be used:
image
image
@niraymak niraymak added the priority Only assign this label if it's asked to assign this label label Jun 28, 2021
@elislaats
Copy link
Contributor

@MeesvanStraten @DaveBouman I'm working on fixing issue #561. But I just realised that if we implement this edit-modal that won't be an issue anymore, since the filters would just stay applied in the background like with the detail-modal.

What do you guys think about that. Would it be better to start on updating & implementing the change mentioned in this issue?

@DaveBouman
Copy link
Contributor

You can continue this issue if you want to. :)

@elislaats elislaats self-assigned this Sep 16, 2021
@MeesvanStraten
Copy link
Contributor

@juliaslaats Hey, Yeah I checked it out and makes sense. This way we have a nice updated edit modal and the filters will still be applied! Good that you mentioned 👍

@MeesvanStraten MeesvanStraten mentioned this issue Sep 16, 2021
Closed
@elislaats elislaats mentioned this issue Sep 24, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elislaats elislaats

Labels
priority Only assign this label if it's asked to assign this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/536 update edit page DigitalExcellence/dex-frontend
5 participants
@MeesvanStraten @niraymak @DaveBouman @RubenFricke @elislaats