Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added styling to the PopOver and Cogwheel. Fixed typo in highlight #568

Merged
merged 3 commits into from
Sep 14, 2021

Conversation

BartvanEijkelenburg
Copy link
Contributor

@BartvanEijkelenburg BartvanEijkelenburg commented Sep 10, 2021

Description

A few sentences describing the overall goals of the pull request's commits.

Type of change

  • [ x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I updated the changelog with an end-user readable description
  • I assigned this pull request to the correct project board to update the sprint board

Steps to Test or Reproduce

Click on the cogwheel on the project modal page.
Changed styling will now show up.

Closes: #461

@BartvanEijkelenburg BartvanEijkelenburg added bug Something isn't working Good first issue Good first issue to get to know the project internally. labels Sep 10, 2021
@BartvanEijkelenburg BartvanEijkelenburg self-assigned this Sep 10, 2021
@DaveBouman DaveBouman self-requested a review September 10, 2021 12:05
Copy link
Contributor

@HansenSven HansenSven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@DaveBouman DaveBouman merged commit 56b438f into develop Sep 14, 2021
@DaveBouman DaveBouman deleted the bug/566-Settings-modal-not-styled-on-project-info branch September 14, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Good first issue Good first issue to get to know the project internally.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants