Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect line number 1 for no_contact and others. #60

Closed
mxsasha opened this issue Aug 23, 2023 · 3 comments
Closed

Incorrect line number 1 for no_contact and others. #60

mxsasha opened this issue Aug 23, 2023 · 3 comments

Comments

@mxsasha
Copy link
Collaborator

mxsasha commented Aug 23, 2023

0.9.0 introduced an issue where errors that do not relate to a specific line, e.g. no_contact or no_expire, have their line set to 1, where this should be None

Suspected cause: initially set to 1 here, and this new code in d56b65a will use that original setting unless an explicit other line number is given, and a None value keeps the existing value.

In other error combinations, I think other incorrect line numbers can occur.

@DigitalTrustCenter
Copy link
Owner

Thank you for reporting this issue. The line number variable was overridden which caused these undesired results. This issue is fixed now.

@mxsasha
Copy link
Collaborator Author

mxsasha commented Mar 25, 2024

This doesn't actually seem to be fixed? Still see the same issue for e.g. no_expire. I also don't see any code changes that I had expected would fix this.

@mxsasha mxsasha reopened this Mar 25, 2024
@bwbroersma
Copy link
Contributor

It was a human off by one error on our side, actually the error on our side was about the somewhat cryptic no_line_separators (should have been called no_newline_on_last_line ;) - but don't change it now), that actually pointing to the last line (and not None) is the correct behavior.

@mxsasha mxsasha closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants