Skip to content

Commit 385da9d

Browse files
author
Dan Lecocq
committed
Rename "failures" to "failed" in qless-stats
Graphite/whisper cannot have a name that serves both as a metric name and as a dot-delimited prefix to another metric. Because individual failure types are reported as "failures.<type>", the "failures" metric fails to be reported if ever there has been a report of "failures.<type>". While this tool is not specific to graphite, it is a common tool in the monitoring ecosystem and it takes little effort to make this tool compatible.
1 parent 7cfe849 commit 385da9d

File tree

4 files changed

+12
-3
lines changed

4 files changed

+12
-3
lines changed

README.md

+9
Original file line numberDiff line numberDiff line change
@@ -663,3 +663,12 @@ Mailing List
663663

664664
For questions and general Qless discussion, please join the [Qless
665665
Mailing list](https://groups.google.com/forum/?fromgroups#!forum/qless).
666+
667+
Release Notes
668+
=============
669+
670+
0.12.0
671+
------
672+
The metric `failures` provided by `qless-stats` has been replaced by `failed` for
673+
compatibility with users of `graphite`. See [#275](https://github.com/seomoz/qless/pull/275)
674+
for more details.

exe/qless-stats

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class Stats < Thor
9696
client.gauge "failures.#{failure}", count
9797
count
9898
end.reduce(0, :+)
99-
client.gauge 'failures', total
99+
client.gauge 'failed', total
100100

101101
# Track workers
102102
client.gauge 'workers', qless.workers.counts.length

lib/qless/version.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Encoding: utf-8
22

33
module Qless
4-
VERSION = '0.11.0'
4+
VERSION = '0.12.0'
55
end

spec/integration/exe/qless_stats_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ def get_statsd_messages
124124
end
125125

126126
it 'tracks total failures' do
127-
expect(messages).to include('failures:1|g')
127+
expect(messages).to include('failed:1|g')
128128
end
129129

130130
it 'tracks worker counts' do

0 commit comments

Comments
 (0)