Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eq_kernel in get_custom_L2 missing contribution of rbr_identity. #99

Open
vchiley opened this issue Aug 30, 2022 · 0 comments
Open

eq_kernel in get_custom_L2 missing contribution of rbr_identity. #99

vchiley opened this issue Aug 30, 2022 · 0 comments

Comments

@vchiley
Copy link

vchiley commented Aug 30, 2022

My interpretation of get_custom_L2 is that L2 decay is applied not to the individual weights being trained, but instead to the deploy equivalent weights.

If this is the motivation, wouldn't the eq_kernel also incorporate the identity from the skip connection when self.rbr_identity is not None? Currently the contribution of rbr_identity in the eq_kernel in get_custom_L2 is missing. Was this intentional? Is there a reference or ablation for why you would exclude it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant