Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify or implement step 4 of the flex layout algorithm #119

Closed
TimJentzsch opened this issue Jun 9, 2022 · 1 comment
Closed

Identify or implement step 4 of the flex layout algorithm #119

TimJentzsch opened this issue Jun 9, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@TimJentzsch
Copy link
Collaborator

What problem does this solve or what need does it fill?

Currently, step 4 of the flex layout algorithm is not explicitly documented. This can mean that the documentation is missing or that the step is not yet implemented.
Since we want to adhere to the specs wherever possible, we need to make sure that we have this step and that documentation explains what it does.

What solution would you like?

  • If the step is implemented, move it to a separate function if possible, document the function similar to the other ones with links to the spec.
  • If the step is not yet implemented, implement it with docs as explained above.

What alternative(s) have you considered?

If the step is not applicable for whatever reason, this still needs to be documented explicitly.

Additional context

Originally discussed in #39.

@TimJentzsch TimJentzsch added the enhancement New feature or request label Jun 9, 2022
@nicoburns
Copy link
Collaborator

Closing this as this step is actually done earlier in "compute constants" in our implementation. #317 updates the comments to point this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants