-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split test fixtures into different folders per algorithm #479
Comments
I would like to work on this issue. This is going to be my first issue on taffy but I think I have a simple understanding of what needs to be done here.
|
Sounds great: let us know if you have any questions :) |
Your understanding sounds correct to me. One detail I would add is that there are two aspects to part 2:
|
Sounds good, that's what I was thinking as well. Will let you know if I have quetsions. |
Two questions;
|
Yes. These are tests that are temporarily disabled, but that we hope to be enable later. They should be grouped under the directory that would be in if they didn't have the
Yes, that's fine :) |
Originally posted by @TimJentzsch in #474 (review)
This would give us the following folders:
flex
grid
block
leaf
gridflex
blockflex
blockgrid
Note:
grid
,block
andleaf
algorithm tests are prefixed withgrid
/block
/leaf
. The remaining unprefixed tests are all flexbox tests. We would likely also need to reorganise the generated tests themselves a little. Perhaps by nesting them in modules corresponding to the directory they originate in.The text was updated successfully, but these errors were encountered: