Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Player Documentation out of date #194

Open
brac3r opened this issue Apr 12, 2023 · 0 comments
Open

Base Player Documentation out of date #194

brac3r opened this issue Apr 12, 2023 · 0 comments

Comments

@brac3r
Copy link

brac3r commented Apr 12, 2023

A while ago an update was made to change base defense modes.

Problem 1
Base Plugin ->PlayerBase.cpp -> float PlayerBase::GetAttitudeTowardsClient
Comments are out of date, saying things like if defense mode 3, at this point if player doesn't match any criteria, give him fireworks. This is no longer the case. I know this is pretty minor but I trusted the comments at first glance of trying to figure out why all the documentation pointed towards one behaviour and the actual behaviour being different.

Problem 2
Base Plugin -> PlayerCommands.cpp -> void BaseHelp
~Line 75, pages[2]

Documentation needs changing for defense mode. ie:
Defense Mode 3 - Logic: Blacklist > Whitelist > Faction Whitelist > Hostile
Above line is what is presented to the client, it is now incorrect. (Docking RIghts is still correct).

What I suggest is something like this be added to the top of the infocard:
All Defense Modes: Can only be hostile if under siege.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant