Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alley -> rep doesn't work #195

Open
brac3r opened this issue Apr 17, 2023 · 2 comments
Open

alley -> rep doesn't work #195

brac3r opened this issue Apr 17, 2023 · 2 comments

Comments

@brac3r
Copy link

brac3r commented Apr 17, 2023

LI06_01_base is Red Base in conn.
rep doesn't work

Result: Reputation is still pf_08_grp. It should be set to li_n_guardian and read Unidentifed to player and be very hostile :)

The code is in alley -> rep.cpp -> void REP::LoadSettings() line 32

It seems to be reading the config file and grabbing the values correctly as it output to console saying as much. Doesn't seem to be setting the rep though, although this code is repeated all over the place as far as I can see so I'm not sure why?

Also as a side note, this pattern:
uint obj_rep_group; pub::Reputation::GetReputationGroup(obj_rep_group, newrep); pub::Reputation::SetAffiliation(solarnick, obj_rep_group);

Should probably be it's own function as I found it repeated a lot throughout the project.

@zibbizor
Copy link
Collaborator

Yeah this is something that I never managed to get to work properly. The one and only instance where it worked it turned Manhattan into a LR base and propagated the hostility to all nearby bases like a virus. You can guess the mess it created in the entire system.

@brac3r
Copy link
Author

brac3r commented Apr 18, 2023

The method of making something x affiliation seems to work in other parts of the code.
For example, HkResetRep and HkSetRep in flhook/HkFuncPlayers.cpp seems to set the player fine.

I can see only two differences, first being a solar instead of a player and when the code is run.
It's silly but have you tried running it on a timer so that it runs 10 seconds are everything else is finished?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants