fix(cli): Forward slashes problem when serving from e.g. S3 (#1800)

somehow the urls generated are like `https://domain//pwa/fb3c65966433393af9889753675af9c9.json`
this will fail when serving those from an S3. so we make sure we normalize them before request

packages/cli/src/extensions/plugins-extensions.ts

@@ -60,9 +60,9 @@ module.exports = (toolbox: GluegunToolbox) => {
  const url =
  config.indexOf(endpoint) >= 0
  ? config
- : `${toolbox.normalizeBaseUrl(
+ : toolbox.normalizeForwardSlashes(`${toolbox.normalizeBaseUrl(
  toolbox.inputParameters.shopwareEndpoint
- )}/${config}`;
+ )}/${config}`);
  const pluginsConfigResponse = await axios.get(url);
  return pluginsConfigResponse.data;
  };
@@ -74,9 +74,9 @@ module.exports = (toolbox: GluegunToolbox) => {
  const fileUrl =
  asset.indexOf(endpoint) >= 0
  ? asset
- : `${toolbox.normalizeBaseUrl(
+ : toolbox.normalizeForwardSlashes(`${toolbox.normalizeBaseUrl(
  toolbox.inputParameters.shopwareEndpoint
- )}/${asset}`;
+ )}/${asset}`);
 
  const request = require("request");
  const loadFile = function () {

packages/cli/src/extensions/shopware-pwa-extension.ts

@@ -143,6 +143,16 @@ module.exports = (toolbox: GluegunToolbox) => {
  return toolbox.strings.trimEnd(baseUrl, "/");
  };
 
+ /**
+ * Removes forward slashes from URLs
+ *
+ * @param { string } baseUrl
+ * @returns { string }
+ */
+ toolbox.normalizeForwardSlashes = (baseUrl: string): string => {
+ return baseUrl.replace(/([^:]\/)\/+/g, "$1")
+ };
+
  /**
  * Checks if provided API has PWA extension installed
  * by making a request to the page resolver