fix(theme): SSR render broken by cookie exception (#195)

* wip(theme): update contextToken only if has changed * test: setting cookie after server response * chore: cleanup data
vuestorefront · Dec 9, 2019 · c61ee74 · c61ee74 · github-actions · Dec 9, 2019
1 parent f7ff086
commit c61ee74
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 6 deletions.
diff --git a/packages/composables/src/hooks/useCart/index.ts b/packages/composables/src/hooks/useCart/index.ts
@@ -19,7 +19,8 @@ export const useCart = (): any => {
  vuexStore.commit("SET_CART", result);
  } catch (e) {
  error.value = e;
- console.error("Problem with fetching data", e.message);
+ console.error("Problem with fetching CART data", e.message);
+ console.error(e);
  } finally {
  loading.value = false;
  }

diff --git a/packages/composables/src/hooks/useCms/index.ts b/packages/composables/src/hooks/useCms/index.ts
@@ -17,7 +17,8 @@ export const useCms = (): any => {
  vuexStore.commit("SET_PAGE", result);
  } catch (e) {
  error.value = e;
- console.error("Problem with fetching data", e.message);
+ console.error("Problem with fetching CMS data", e.message);
+ console.error(e);
  } finally {
  loading.value = false;
  }

diff --git a/packages/composables/src/hooks/useProduct/index.ts b/packages/composables/src/hooks/useProduct/index.ts
@@ -38,7 +38,8 @@ export const useProduct = (
  return result;
  } catch (e) {
  error.value = e;
- console.error("Problem with fetching data", e.message);
+ console.error("Problem with fetching PRODUCT data", e.message);
+ console.error(e);
  } finally {
  loading.value = false;
  }

diff --git a/packages/default-theme/plugins/api-client.js b/packages/default-theme/plugins/api-client.js
@@ -18,9 +18,13 @@ export default ({ app, store }) => {
  * Save current contextToken when its change
  */
  onConfigChange(({ config }) => {
- app.$cookies.set('sw-context-token', config.contextToken, {
- maxAge: 60 * 60 * 24 * 365
- })
+ try {
+ app.$cookies.set('sw-context-token', config.contextToken, {
+ maxAge: 60 * 60 * 24 * 365
+ })
+ } catch (e) {
+ // Sometimes cookie is set on server after request is send, it can fail silently
+ }
  })
 
  // Temporary fix for SSR and reactivity