Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(composables): is in cart condition #1032

Merged
merged 1 commit into from
Aug 20, 2020
Merged

fix(composables): is in cart condition #1032

merged 1 commit into from
Aug 20, 2020

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Aug 19, 2020

Changes

  • prevents from seeing 500 while browsing product cards not contained in product listing (like custom cms block).
  • refactor of condition (aligned with 6.3 API change)

Checklist

@vercel
Copy link

vercel bot commented Aug 19, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/4i5qwp2vs
✅ Preview: https://shopware-pwa-docs-git-fix-is-in-cart-issue.shopware-pwa.vercel.app

@github-actions
Copy link

💙 shopware-pwa-canary successfully deployed at https://49f0e892f54142d679d75dece208097d60cdfbc4.shopware-pwa-canary.preview.storefrontcloud.io

@patzick patzick merged commit 37f7b8a into master Aug 20, 2020
@patzick patzick deleted the fix/is-in-cart-issue branch August 20, 2020 08:39
@patzick patzick added this to the v0.4.0 milestone Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mkucmus @patzick