Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(default-theme): Added translation for customer account and checkout translation #1147

Conversation

st-mothership
Copy link
Contributor

@st-mothership st-mothership commented Oct 2, 2020

Changes

closes #1147

Checklist

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2020

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to Preview October 2, 2020 11:39 Inactive
@vercel
Copy link

vercel bot commented Oct 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/e931z1fhb
✅ Preview: https://shopware-pwa-docs-git-064259c457e2db69578efb2508650822eb650107.shopware-pwa.vercel.app

@vercel vercel bot temporarily deployed to preview October 2, 2020 11:42 Inactive
@vercel vercel bot temporarily deployed to preview October 2, 2020 11:49 Inactive
@vercel vercel bot temporarily deployed to preview October 2, 2020 13:17 Inactive
@vercel vercel bot temporarily deployed to preview October 2, 2020 13:29 Inactive
@st-mothership st-mothership changed the title 1140 customer account and checkout translation feat(default-theme): Added translation for customer account and checkout translation Oct 2, 2020
@st-mothership st-mothership marked this pull request as ready for review October 2, 2020 14:23
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what a massive job 💪 🇬🇧

@mkucmus
Copy link
Collaborator

mkucmus commented Oct 6, 2020

@st-mothership could you resolve the conflicts that appeared recently?

@mkucmus mkucmus linked an issue Oct 6, 2020 that may be closed by this pull request
@vercel vercel bot temporarily deployed to preview October 6, 2020 09:25 Inactive
@niklaswolf
Copy link
Collaborator

@mkucmus done ;)

@mkucmus mkucmus merged commit f8a5faf into vuestorefront:master Oct 6, 2020
@niklaswolf niklaswolf deleted the 1140-customer-account-and-checkout-translation branch October 6, 2020 09:44
@patzick patzick added this to the v0.5.0 milestone Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Make customer account and checkout components translatable
5 participants