Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(default-theme): bottom navigation modal invocation #1695

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Sep 30, 2021

Changes

While trying to reproduce #1600 I've found that the bottom navi is not opening login window. his PR fixes this issue.

@patzick patzick added this to the v1.0.0-RC.3 milestone Sep 30, 2021
@vercel
Copy link

vercel bot commented Sep 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/FDyom5eobwqoYjgkKyutjStZ9nMx
✅ Preview: Canceled

@github-actions
Copy link

💙 shopware-pwa-canary successfully deployed at https://df1bc82a4736b53e5ba5a05fa4484800e97170ae.shopware-pwa-canary.preview.storefrontcloud.io

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bye, rootContext, our good, old friend 💙 We will miss you 😢

@patzick patzick merged commit 89d2fa8 into master Sep 30, 2021
@patzick patzick deleted the fix/default-theme/bottom-navigation-login-modal branch September 30, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants