Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composables): injected cms page in useListing and useProductConfigurator #1706

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Oct 12, 2021

Changes

Fixing issue with proper cms context in useListing and useProductConfigurator to use injected cms-page first.

@patzick patzick added this to the v1.0.0-RC.3 milestone Oct 12, 2021
@patzick patzick requested a review from mkucmus October 12, 2021 17:49
@vercel
Copy link

vercel bot commented Oct 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/CtPohZiewvHtQeGsaYFEo1R2bEEd
✅ Preview: https://shopware-pwa-docs-git-fix-cms-page-context-shopware-pwa.vercel.app

[Deployment for 9e13a99 canceled]

@github-actions
Copy link

💙 shopware-pwa-canary successfully deployed at https://f93baecf895128e856c0d594db5f5de9cef00345.shopware-pwa-canary.preview.storefrontcloud.io

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inject provided very nicely!

@patzick patzick merged commit e72b5b8 into master Oct 13, 2021
@patzick patzick deleted the fix-cms-page-context branch October 13, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants