Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composables): wrong association on product page #1707

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

mkucmus
Copy link
Collaborator

@mkucmus mkucmus commented Oct 12, 2021

Changes

closes: #1705

  • error occures only on vv6.4.5.1 of Shopware
  • removes obsolete association on useCms search request
    (since cross selling products are fetched asynchronously via dedicated endpoint, using that on useCms level is redundand).

Checklist

@vercel
Copy link

vercel bot commented Oct 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/7ecvqMYgqV2itAo5yZ5Hwga1jxCg
✅ Preview: Canceled

[Deployment for 785206c canceled]

@mkucmus mkucmus requested a review from patzick October 12, 2021 19:24
@mkucmus
Copy link
Collaborator Author

mkucmus commented Oct 12, 2021

chore: lint

@github-actions
Copy link

github-actions bot commented Oct 12, 2021

💙 shopware-pwa-canary successfully deployed at https://e3c604ccc6f4927f3c643bc3c0cbcd2c90dae2b6.shopware-pwa-canary.preview.storefrontcloud.io

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗑️

@patzick patzick merged commit 4c3ccf5 into master Oct 13, 2021
@patzick patzick deleted the fix/product-page-cross-sells branch October 13, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Product page Error 500
2 participants