Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helpers): remove field check and use explicit field for product name #310

Merged
merged 1 commit into from
Jan 21, 2020
Merged

fix(helpers): remove field check and use explicit field for product name #310

merged 1 commit into from
Jan 21, 2020

Conversation

elkmod
Copy link
Collaborator

@elkmod elkmod commented Jan 21, 2020

No description provided.

@mkucmus
Copy link
Collaborator

mkucmus commented Jan 21, 2020

@elkmod now it's clear we need to use always translated name.
please adjust the tests and will be fine 👍

@elkmod elkmod force-pushed the fix/use-explicit-product-name branch from ea998f4 to a43d1e3 Compare January 21, 2020 10:30
patzick
patzick approved these changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 great, thanks! :)

@patzick patzick merged commit f2b42c2 into vuestorefront:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elkmod @mkucmus @patzick