Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme): adjustment to new SFUI version with CSS variables #442

Merged
merged 20 commits into from
Mar 3, 2020
Merged

feat(theme): adjustment to new SFUI version with CSS variables #442

merged 20 commits into from
Mar 3, 2020

Conversation

krskibin
Copy link
Collaborator

@krskibin krskibin commented Feb 26, 2020 •
edited
Loading

closes: #420 #448

Changes

  • changed all scss variables to css variables (Storefront UI breaking change)
  • updated storefront-ui to 0.6.0

Checklist

  • I followed code and contributing guidelines
  • I wrote all needed tests

@krskibin krskibin changed the title feat(theme): working templates with css variables feat(theme): adjustment to new SFUI version with CSS variables Feb 26, 2020
@github-actions
Copy link

github-actions bot commented Feb 26, 2020 •
edited
Loading

Deploy preview for website ready!

Built with commit bf6af67

https://shopware-pwa-lpuenl47h.now.sh

krskibin and others added 13 commits February 26, 2020 23:44
@krskibin krskibin marked this pull request as ready for review February 28, 2020 08:51
@krskibin krskibin mentioned this pull request Feb 28, 2020
Closed
@krskibin krskibin linked an issue Feb 28, 2020 that may be closed by this pull request
[BUG] components do not compile; Undefined variable: "$spacer". #448
Closed
@krskibin krskibin self-assigned this Feb 28, 2020
@patzick
Copy link
Collaborator

patzick commented Feb 29, 2020

Something is broken in mobile view.
@krskibin @aniamusial could you take a look?
image

patzick
patzick approved these changes Mar 3, 2020
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geat collaboration with @aniamusial ✨

@patzick patzick merged commit 21357de into master Mar 3, 2020
@patzick patzick deleted the feat/theme/css-variables branch March 3, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

Assignees

@krskibin krskibin

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@krskibin @patzick