Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change way of displaying breadcrumbs and plugin top navigation #511

Merged
merged 4 commits into from
Mar 24, 2020

Conversation

Michal-Dziedzinski
Copy link
Collaborator

closes: #503

Changes

Change the way of displaying breadcrumbs and plugin top navigation

Screenshots of visual changes

Before:
image
After:
image

Checklist

  • I followed code and contributing guidelines
  • [] I wrote all needed tests

@github-actions
Copy link

github-actions bot commented Mar 18, 2020

💙 shopware-pwa successfully deployed at https://d5784398f892649d6663fc5aee7f4a9db00ef5b7.shopware-pwa.preview.storefrontcloud.io

Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach breaks views:
image
image

The only thing what we should do here is reducing distance beetween sections, they still should be independent and breadcrumbs below plugin :)

@Michal-Dziedzinski
Copy link
Collaborator Author

Ok, so I misunderstood the issue ;)

@Michal-Dziedzinski Michal-Dziedzinski force-pushed the fix/503-breadcrumbs-and-plugin-layout branch from 3eec2d4 to e550a20 Compare March 19, 2020 08:33
@patzick
Copy link
Collaborator

patzick commented Mar 19, 2020

@Michal-Dziedzinski, unfortunately, looks bad on mobile when there is no plugin:
image

@Michal-Dziedzinski
Copy link
Collaborator Author

@patzick this change shoul fix the problem

@patzick patzick requested a review from akrajna March 23, 2020 13:06
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distance between sections: plugins and breadcrumbs is proper.
The distance between breadcrumbs and sections below is too big - it will be done in this issue #537

@patzick patzick merged commit 8e1885f into master Mar 24, 2020
@patzick patzick deleted the fix/503-breadcrumbs-and-plugin-layout branch March 24, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Breadcrumbs are not displaying poperly with installed plugin
3 participants