Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: currency switch not reloading page #771 #778

Merged
merged 2 commits into from
May 25, 2020
Merged

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented May 24, 2020

Changes

closes #771

Fixes issue with not reloading the page after currency change and error while reading search query.
Speeds up the process by ~700ms by not waiting for unnecessary requests.

Checklist

@patzick patzick requested a review from mkucmus May 24, 2020 11:56
@vercel
Copy link

vercel bot commented May 24, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/aj43i7emk
✅ Preview: https://shopware-pwa-docs-git-fix-currency-switch.shopware-pwa.now.sh

Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

💙 shopware-pwa-canary successfully deployed at https://acb2c5b30463c4403537ccadf5594b7403dd25c5.shopware-pwa-canary.preview.storefrontcloud.io

@patzick patzick merged commit 4ed7917 into master May 25, 2020
@patzick patzick deleted the fix-currency-switch branch May 25, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Currency switch doesn't update price
2 participants