Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: product carousel on mobile in the horizontal position #833

Merged
merged 3 commits into from
Jun 8, 2020
Merged

fix: product carousel on mobile in the horizontal position #833

merged 3 commits into from
Jun 8, 2020

Conversation

pspaczek
Copy link
Collaborator

@pspaczek pspaczek commented Jun 2, 2020

Changes

closes #783

Zrzut ekranu 2020-06-2 o 10 01 07
Zrzut ekranu 2020-06-2 o 10 01 17

Checklist

@vercel
Copy link

vercel bot commented Jun 2, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/l1trbvynb
✅ Preview: https://shopware-pwa-docs-git-fix-product-in-carousel-horizontal.shopware-pwa.now.sh

@github-actions
Copy link

github-actions bot commented Jun 2, 2020 •
edited
Loading

💙 shopware-pwa-canary successfully deployed at https://852e8721e0ad16f881d09fcc7f0c5eff96aa1273.shopware-pwa-canary.preview.storefrontcloud.io

akrajna
akrajna suggested changes Jun 2, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • On home page in section 'Bestsellers' works ok but it would be more user friendly if the pictures were smaller - same size as on product listing page.
    CarouselHome

  • on Product Page in the section 'You may also like' the spaces between products are still too big

CarouselPP

@vercel vercel bot temporarily deployed to preview June 5, 2020 07:40 Inactive
@pspaczek
Copy link
Collaborator Author

pspaczek commented Jun 5, 2020

@akrajna I overrode breakpoints for carousel, now it has 2 items just on vertical mobile.
Zrzut ekranu 2020-06-5 o 09 37 11
Zrzut ekranu 2020-06-5 o 09 37 16
Zrzut ekranu 2020-06-5 o 09 37 27
Zrzut ekranu 2020-06-5 o 09 37 44

@pspaczek pspaczek requested a review from akrajna June 5, 2020 07:42
@akrajna
Copy link
Collaborator

akrajna commented Jun 8, 2020

works great

@patzick patzick merged commit aabc31e into master Jun 8, 2020
@patzick patzick deleted the fix/product-in-carousel-horizontal branch June 8, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

@akrajna akrajna akrajna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]Carousel is not displayed correctly in the horizontal position of the phone
3 participants
@pspaczek @akrajna @patzick