Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(default-theme): remove duplicated product description #882

Merged
merged 6 commits into from
Jun 25, 2020
Merged

fix(default-theme): remove duplicated product description #882

merged 6 commits into from
Jun 25, 2020

Conversation

luklus
Copy link
Contributor

@luklus luklus commented Jun 22, 2020 •
edited
Loading

Changes

closes #867

Checklist

@vercel
Copy link

vercel bot commented Jun 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/kk6i8g9l4
✅ Preview: In Progress

(2231cfe, update in progress)

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to preview June 22, 2020 09:58 Inactive
@patzick patzick changed the title fix(default-theme): remove duplicated description fix(default-theme): remove duplicated product description Jun 22, 2020
@vercel vercel bot temporarily deployed to preview June 23, 2020 08:29 Inactive
@vercel vercel bot temporarily deployed to preview June 23, 2020 12:25 Inactive
@github-actions
Copy link

github-actions bot commented Jun 23, 2020 •
edited
Loading

💙 shopware-pwa-canary successfully deployed at https://c3372df079e9cecee284d635a242c0daef095028.shopware-pwa-canary.preview.storefrontcloud.io

akrajna
akrajna suggested changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting description from the tab below 'Add to cart' button resulted in no description on mobile at all. On mobile devices there was only one description visible - the one in the tab. After this changes no description will be visible.
Consider deleting the description above 'Add to cart' button.
MobileNoProductDescription

@vercel vercel bot temporarily deployed to preview June 24, 2020 08:18 Inactive
@luklus
Copy link
Contributor Author

luklus commented Jun 24, 2020

@akrajna description on mobile added
Zrzut ekranu z 2020-06-24 10-21-37
:

@vercel vercel bot temporarily deployed to preview June 25, 2020 09:24 Inactive
@patzick patzick merged commit 30ed7dd into master Jun 25, 2020
@patzick patzick deleted the fix(default-theme)/description-is-displayed-2-times-#867 branch June 25, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akrajna akrajna akrajna requested changes

@patzick patzick patzick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Description is displayed 2 times
6 participants
@luklus @CLAassistant @patzick @akrajna @llusiak @mkucmus