Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(default-theme): my account address management buttons #455 #887

Merged
merged 12 commits into from
Jul 1, 2020
Merged

fix(default-theme): my account address management buttons #455 #887

merged 12 commits into from
Jul 1, 2020

Conversation

luklus
Copy link
Contributor

@luklus luklus commented Jun 23, 2020 •
edited
Loading

Changes

closes #455

Checklist

@vercel
Copy link

vercel bot commented Jun 23, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/apbpny0pt
✅ Preview: https://shopware-pwa-d-git-fixdefault-theme-align-back-button-on-d0dda9.shopware-pwa.vercel.app

@github-actions
Copy link

github-actions bot commented Jun 23, 2020 •
edited
Loading

💙 shopware-pwa-canary successfully deployed at https://939954327233d54326e72464b97392576fe4bbd8.shopware-pwa-canary.preview.storefrontcloud.io

@luklus luklus changed the title fix(default-theme): align button fix(default-theme): align button #455 Jun 23, 2020
akrajna
akrajna approved these changes Jun 23, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine

patzick
patzick requested changes Jun 25, 2020
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add small margin on mobile like in personal details
image

now it is
image

@vercel vercel bot temporarily deployed to preview June 29, 2020 08:47 Inactive
@vercel vercel bot temporarily deployed to preview June 29, 2020 11:27 Inactive
@vercel vercel bot temporarily deployed to preview June 29, 2020 11:42 Inactive
patzick
patzick requested changes Jun 29, 2020
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not right
image

  • no space on address editing
    image

@vercel vercel bot temporarily deployed to preview June 29, 2020 12:10 Inactive
@vercel vercel bot temporarily deployed to preview June 29, 2020 13:27 Inactive
@vercel vercel bot temporarily deployed to preview June 30, 2020 06:41 Inactive
akrajna
akrajna suggested changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no margins in address edit page on mobile
Margins-my-account-edit-adres

@luklus
Copy link
Contributor Author

luklus commented Jun 30, 2020

Fixed

Zrzut ekranu z 2020-06-30 10-45-35
Zrzut ekranu z 2020-06-30 10-56-54

@vercel vercel bot temporarily deployed to preview June 30, 2020 09:04 Inactive
akrajna
akrajna approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@akrajna akrajna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

@vercel vercel bot temporarily deployed to preview July 1, 2020 10:00 Inactive
patzick
patzick approved these changes Jul 1, 2020
View reviewed changes
Copy link
Collaborator

@patzick patzick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's perfect 👌 thank you!

@patzick patzick changed the title fix(default-theme): align button #455 fix(default-theme): my account address management buttons #455 Jul 1, 2020
@patzick patzick merged commit 8b3d94f into master Jul 1, 2020
@patzick patzick deleted the fix(default-theme)/align-back-button-on-mobile branch July 1, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patzick patzick patzick approved these changes

@akrajna akrajna akrajna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]My account- update the addresses- 'Back' button needs to be aligned on mobile
3 participants
@luklus @patzick @akrajna