Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): improve DX by triggering rebuild on changes #937

Merged
merged 6 commits into from
Jul 8, 2020

Conversation

patzick
Copy link
Collaborator

@patzick patzick commented Jul 8, 2020

Changes

closes #869
improvements in DX

  • package.json will be changed during init to invoke shopware-pwa dev or shopware-pwa build
  • files are watched and proper commands are invoked on those changes

it watches for those events (test scenarios):

  • override component
  • change anything in CMS components
  • change something in local plugins
  • change local translations
  • change local plugins translations

Checklist

@patzick patzick requested a review from mkucmus July 8, 2020 11:18
@vercel
Copy link

vercel bot commented Jul 8, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shopware-pwa/shopware-pwa-docs/5v2fqfq2s
✅ Preview: https://shopware-pwa-docs-git-feat-dev-experience-invoke-rebuild.shopware-pwa.vercel.app

@mkucmus
Copy link
Collaborator

mkucmus commented Jul 8, 2020

I can confirm that rebuilding is triggered by:
✅ override component
✅ change anything in CMS components
✅ : change something in local plugins
✅ change local translations
✅ change local plugins translations

so from the typical user perspective everything is fine 💪

@vercel vercel bot temporarily deployed to preview July 8, 2020 12:33 Inactive
@vercel vercel bot temporarily deployed to preview July 8, 2020 12:38 Inactive
@vercel vercel bot temporarily deployed to preview July 8, 2020 12:45 Inactive
@vercel vercel bot temporarily deployed to preview July 8, 2020 13:01 Inactive
Copy link
Collaborator

@mkucmus mkucmus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the functional perspective - everything is fine and works like a charm 💪

@vercel vercel bot temporarily deployed to preview July 8, 2020 13:14 Inactive
@github-actions
Copy link

github-actions bot commented Jul 8, 2020

💙 shopware-pwa-canary successfully deployed at https://3cda96b49ee11ce567d1712c96c720a70eb29b23.shopware-pwa-canary.preview.storefrontcloud.io

@patzick patzick merged commit e6ef5f3 into master Jul 8, 2020
@patzick patzick deleted the feat-dev-experience-invoke-rebuild branch July 8, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Files in sw-plugins will not trigger rebuild
2 participants