Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrapper for DMM Seems to be Broken #325

Open
rickytor81 opened this issue Jul 16, 2020 · 18 comments
Open

Scrapper for DMM Seems to be Broken #325

rickytor81 opened this issue Jul 16, 2020 · 18 comments
Labels

Comments

@rickytor81
Copy link

The scrapper for DMM appears to be broken. Would be great if it can be fixed.

Thanks

@rickytor81 rickytor81 added the bug label Jul 16, 2020
@zuko7177
Copy link
Contributor

zuko7177 commented Jul 29, 2020

Broken due to age check on DMM.jo.co site.

Pull request to handle the age check: #326

@zuko7177 zuko7177 mentioned this issue Aug 1, 2020
@huihuijordan
Copy link

The scrapper for DMM appears to be broken. Would be great if it can be fixed.

Thanks

I have the same problem as yours, the DMM can not be accessed for one month.

@huihuijordan
Copy link

Broken due to age check on DMM.jo.co site.

Pull request to handle the age check: #326

Could you please give me a working release jar? Many thanks, jia19870807@163.com

@koonfoon
Copy link

Broken due to age check on DMM.jo.co site.

Pull request to handle the age check: #326

Hi,
I cloned the master branch from your repository.
I run gradle shadowJar and produced a .jar file.
But the DMM is still broken for me.

@zuko7177
Copy link
Contributor

zuko7177 commented Aug 14, 2020

DMM scraper may still be broken because it uses grammarchecker.net to do JP to EN translations. I've observed that site is not reliable (perhaps due to too many calls?). If the call to that site returns nothing, DMM scraper will not have English data.

Try enabling Preference -> Translation -> Scrape JAV Movies in Japanese Instead Of English

If DMM scraper returns JP data, then you know the translation is down. You can try waiting a day to see if EN translation is working again.

@zuko7177
Copy link
Contributor

zuko7177 commented Aug 14, 2020

I just tested DMM scraping and the translation feature is not working. Indeed, this is due to grammarcheck.net not returning translations. It will look like this:
image

I also went to test https://grammarchecker.net/translate/ and the translation feature is not working.

DMM scraping in JP is working OK.
image

@koonfoon
Copy link

DMM may still be broken because it uses grammarchecker.net to do JP to EN translations. I've observed that site is not reliable (perhaps due to too many calls?). If the call to that site returns nothing, DMM will not have English data.

Try enabling Preference -> Translation -> Scrape JAV Movies in Japanese Instead Of English

If DMM returns JP data, then you know the translation is down. You can try waiting a day to see if EN translation is working again.

Thank you 👍

@JK0304
Copy link

JK0304 commented Aug 20, 2020

@koonfoon : Hello, can you share me your jar file, i'm trying to build a jar file but no luck, thank you very much.

@neko29ssn
Copy link

neko29ssn commented Aug 22, 2020

Hi @koonfoon, which JDK you used to setup this project?
sorry I know it is dumb question, I really not familiar with java @@
I have no luck trying with intellij + jdk 11 in windows 10

Thanks in advanced

@tonyzzz321
Copy link

@JK0304 @neko29ssn
This is how I successfully built the jar. I don't have any IDE. My JDK version is 11.0.8 and Gradle is at version 5.6.4.
I cloned zuko7177's fork (https://github.com/zuko7177/JAVMovieScraper) and then run "gradle shadowjar" to build the jar. The output jar file is located in build/libs/ folder.
Hope this helps.

@JK0304
Copy link

JK0304 commented Aug 23, 2020

@tonyzzz321 : I successfully create a jar file thanks for your guide but bad new is i can't open it, hope you can help me out.
Untitled

@neko29ssn
Copy link

@JK0304 @neko29ssn
This is how I successfully built the jar. I don't have any IDE. My JDK version is 11.0.8 and Gradle is at version 5.6.4.
I cloned zuko7177's fork (https://github.com/zuko7177/JAVMovieScraper) and then run "gradle shadowjar" to build the jar. The output jar file is located in build/libs/ folder.
Hope this helps.

It work like a charm :D
Thank you so much @tonyzzz321 !!

@tonyzzz321
Copy link

@JK0304
Can you run "gradle -v" to see what version of Gradle you have? Make sure you have version 5.6.4, not the latest version. I think the new version of Gradle updated something on how to configure the build, and JAVMovieScraper hasn't been updated hence not compatible with new version of Gradle.

@Wizell
Copy link
Collaborator

Wizell commented Aug 23, 2020

@tonyzzz321 is right. But this should be fixed in master.

I need to fix few more things and i will do a new release

@JK0304
Copy link

JK0304 commented Aug 24, 2020

@JK0304
Can you run "gradle -v" to see what version of Gradle you have? Make sure you have version 5.6.4, not the latest version. I think the new version of Gradle updated something on how to configure the build, and JAVMovieScraper hasn't been updated hence not compatible with new version of Gradle.

Oh man, i use the latest Gradle version, that's why i can't open jar file, it's working now, thank you very much for your help, cheers

@zuko7177
Copy link
Contributor

zuko7177 commented Aug 25, 2020

@Wizell May I suggest committing the Gradle Wrapper to repository. This should remove issues with Gradle version compatibility.

JAVMovieScraper\gradle\wrapper\gradle-wrapper.jar
JAVMovieScraper\gradle\wrapper\gradle-wrapper.properties
JAVMovieScraper\gradlew
JAVMovieScraper\gradlew.bat

@rickytor81
Copy link
Author

@JK0304 @neko29ssn
This is how I successfully built the jar. I don't have any IDE. My JDK version is 11.0.8 and Gradle is at version 5.6.4.
I cloned zuko7177's fork (https://github.com/zuko7177/JAVMovieScraper) and then run "gradle shadowjar" to build the jar. The output jar file is located in build/libs/ folder.
Hope this helps.

Thank you for the solution! It works!!

@zuko7177
Copy link
Contributor

For building a jar from my repo, see #335 (comment)

Hopefully, @Wizell will approve the PR and build the next official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants