Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moduleFilters: files are logged multiple times #682

Open
1 task
Domiii opened this issue Feb 20, 2022 · 0 comments
Open
1 task

Fix moduleFilters: files are logged multiple times #682

Domiii opened this issue Feb 20, 2022 · 0 comments
Assignees
Labels
bug Something isn't working priority

Comments

@Domiii
Copy link
Owner

Domiii commented Feb 20, 2022

NOTES:

  • In our new system, moduleFilters can be registered on multiple levels: 1. as the include or ignore babel option, 2. as an option to the Dbux plugin itself, because include/ignore is controlled by the build system, and should not be tempered with.
  • Make sure that if we have multiple filters at different stages, they only log once anyway.

TODO

  • Fix: Currently, when building react-tic-tac-toe, some files are logged 4 times with [REGISTER]. Any whitelisted file should ideally only appear once.
    • Everything works fine though...
@Domiii Domiii added bug Something isn't working priority labels Feb 20, 2022
@Domiii Domiii assigned MiccWan and Domiii and unassigned MiccWan Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
Development

No branches or pull requests

2 participants