Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add optional sort key to models. #236

Closed
Symbiomatrix opened this issue Sep 12, 2023 · 2 comments · Fixed by #237
Closed

[Enhancement] Add optional sort key to models. #236

Symbiomatrix opened this issue Sep 12, 2023 · 2 comments · Fixed by #237
Assignees
Labels
enhancement New feature or request

Comments

@Symbiomatrix
Copy link
Contributor

Symbiomatrix commented Sep 12, 2023

Hello dom, would it be possible to add an optional comma delimited numerical priority value to each model written in the temp files for loras, embeddings, lycos etc, so that the whole shouldSort segment first orders the models by priority instead of lexicographically?

I've written in a small modification to the get_x functions so that they sort model lists by modification date (per setting), plus other priority ratings, but without additional information the order cannot be preserved when the categories are later merged on the js side. I hardly have the wherewithal to write working code in js, so I'd appreciate your thoughts on this.

@DominikDoom
Copy link
Owner

I'm actually currently working on a similar themed addition, which is recording usage frequency and factoring that into the order. So basically, the stuff you use most often being recommended at the top. Don't know how long it will take me, though.

I started it mainly for normal tags, but expanding it to Loras, embeddings, etc. is also something I want to do after the first iteration is done. Adding other sort keys like you suggested shouldn't be a big deal once such a system is implemented.

@DominikDoom DominikDoom added the enhancement New feature or request label Sep 12, 2023
@DominikDoom DominikDoom self-assigned this Sep 12, 2023
@Symbiomatrix
Copy link
Contributor Author

Symbiomatrix commented Sep 12, 2023

Alright, cool. If it helps, I'll PR the python side of the sort selection once I've cleaned up the code a bit.

@DominikDoom DominikDoom linked a pull request Sep 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants