fix #915 MultiSelect#deselectAt() doesn't deselecting the item

Author: vegegoku

domino-ui/src/main/java/org/dominokit/domino/ui/forms/suggest/AbstractSelect.java

@@ -858,6 +858,12 @@ public Optional<O> findOptionByKey(String key) {
         .findFirst();
   }
 
+  private Optional<AbstractMenuItem<T>> findMenuItemByKey(String key) {
+    return optionsMenu.getFlatMenuItems().stream()
+        .filter(menuItem -> Objects.equals(key, menuItem.getKey()))
+        .findFirst();
+  }
+
   /**
    * Searches for an option by its value within the select component.
    *
@@ -872,6 +878,12 @@ public Optional<O> findOptionByValue(T value) {
         .findFirst();
   }
 
+  private Optional<AbstractMenuItem<T>> findMenuItemByValue(T value) {
+    return optionsMenu.getFlatMenuItems().stream()
+        .filter(menuItem -> Objects.equals(value, menuItem.getValue()))
+        .findFirst();
+  }
+
   /**
    * Searches for an option by its index within the select component.
    *
@@ -880,9 +892,12 @@ public Optional<O> findOptionByValue(T value) {
    *     found.
    */
   public Optional<O> findOptionByIndex(int index) {
+    return findMenuItemByIndex(index).map(item -> OptionMeta.<T, E, O>get(item).get().getOption());
+  }
+
+  private Optional<AbstractMenuItem<T>> findMenuItemByIndex(int index) {
     if (index < optionsMenu.getFlatMenuItems().size() && index >= 0) {
-      AbstractMenuItem<T> menuItem = optionsMenu.getFlatMenuItems().get(index);
-      return Optional.ofNullable(OptionMeta.<T, E, O>get(menuItem).get().getOption());
+      return Optional.ofNullable(optionsMenu.getFlatMenuItems().get(index));
     }
     return Optional.empty();
   }
@@ -1001,7 +1016,7 @@ public C deselectAt(int index) {
    * @return an instance of the concrete class.
    */
   public C deselectAt(int index, boolean silent) {
-    findOptionByIndex(index).ifPresent(o -> onOptionDeselected(o, silent));
+    findMenuItemByIndex(index).ifPresent(item -> item.deselect(silent));
     return (C) this;
   }
 
@@ -1026,7 +1041,7 @@ public C deselectByKey(String key) {
    * @return an instance of the concrete class.
    */
   public C deselectByKey(String key, boolean silent) {
-    findOptionByKey(key).ifPresent(o -> onOptionDeselected(o, silent));
+    findMenuItemByKey(key).ifPresent(item -> item.deselect(silent));
     return (C) this;
   }
 
@@ -1050,7 +1065,7 @@ public C deselectByValue(T value) {
    * @return an instance of the concrete class.
    */
   public C deselectByValue(T value, boolean silent) {
-    findOptionByValue(value).ifPresent(o -> onOptionDeselected(o, silent));
+    findMenuItemByValue(value).ifPresent(item -> item.deselect(silent));
     return (C) this;
   }