Skip to content

Commit cd52a72

Browse files
committed
fix #926 Select with many entries / Unable to scroll on touch devices
1 parent 25dbe58 commit cd52a72

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

domino-ui/src/main/java/org/dominokit/domino/ui/menu/AbstractMenuItem.java

-4
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,6 @@ public AbstractMenuItem() {
104104
this.addEventListener(
105105
EventType.touchstart.getName(),
106106
evt -> {
107-
evt.stopPropagation();
108-
evt.preventDefault();
109107
focus();
110108
openSubMenu();
111109
});
@@ -148,8 +146,6 @@ public <T extends AbstractMenuItem<V>> T setSelectable(boolean selectable) {
148146
}
149147

150148
private void onSelected(Event evt) {
151-
evt.stopPropagation();
152-
evt.preventDefault();
153149
if (parent.isMultiSelect() && isSelected()) {
154150
deselect();
155151
} else {

domino-ui/src/main/java/org/dominokit/domino/ui/menu/Menu.java

+3
Original file line numberDiff line numberDiff line change
@@ -402,6 +402,9 @@ public Menu() {
402402
0);
403403
}
404404
};
405+
406+
this.addEventListener(EventType.touchstart.getName(), Event::stopPropagation);
407+
this.addEventListener(EventType.touchend.getName(), Event::stopPropagation);
405408
}
406409

407410
public void focusFirstMatch(String token) {

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
8585
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
8686
<elemental2.version>1.2.1</elemental2.version>
87-
<gwt.version>2.10.0</gwt.version>
87+
<gwt.version>2.11.0</gwt.version>
8888
<jackson.apt.version>1.0.4</jackson.apt.version>
8989
<gwt.i18n.version>1.0.2</gwt.i18n.version>
9090
<domino.doc.tool.version>1.0.0</domino.doc.tool.version>

0 commit comments

Comments
 (0)