Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent PNG -> jpeg shows black background. #119

Closed
zehawki opened this issue Sep 11, 2021 · 3 comments
Closed

Transparent PNG -> jpeg shows black background. #119

zehawki opened this issue Sep 11, 2021 · 3 comments

Comments

@zehawki
Copy link

zehawki commented Sep 11, 2021

Transparent PNG -> jpeg shows black background.

Should be white, thats the accepted approach for such conversion.

I see this happening with any transparent PNG, when converted to jpeg shows black. Eg https://www.transparentpng.com/download/happy-st-patricks-day-_34433.html produces:

image

@Donaldcwl Donaldcwl mentioned this issue Sep 26, 2021
@Donaldcwl
Copy link
Owner

For a transparent png file with jpeg file extension, the previous version produces a black background.
In version 1.0.16, the new behavior will result in white background.
Thanks.

@nikkimoreaux
Copy link

Hi! Great little utility thank you! Just a suggestion, white background should always apply to PNG > JPEG conversions; currently v1.0.16 doesn't use white background with the fileType: 'image/jpeg' option. Have a nice day!

@Donaldcwl
Copy link
Owner

@nikkimoreaux Will apply this in the next version, thanks!!

@Donaldcwl Donaldcwl mentioned this issue Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants