New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: iOS and browser detection for iPads #223

Closed

Russell-Pollari wants to merge 2 commits into Donaldcwl:master from Russell-Pollari:fix-for-ipad

Russell-Pollari commented Aug 28, 2024 •

edited

Loading

closes: #222

if isIOS() is true, use IOS as the browser to ensure max canvas size is not exceeded on iPads
update the isIOS util based on this SO answer: https://stackoverflow.com/a/58065241

Author

Russell-Pollari commented Aug 28, 2024

having some trouble running tests on my machine (M1 mac)

Russell-Pollari added 2 commits

August 28, 2024 14:12


          Update isIOS util and use for getting browser

52daff6


          Build

02fc937

Russell-Pollari force-pushed the fix-for-ipad branch from f235bcd to 02fc937 Compare

August 28, 2024 18:13

Russell-Pollari changed the title ~~Update isIOS util and use to determine browser~~ fix: iOS and browser detection for iPads

Russell-Pollari marked this pull request as ready for review

August 28, 2024 18:17

Russell-Pollari closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet