Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify output + improve types + clean readme #25

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

DoneDeal0
Copy link
Owner

@DoneDeal0 DoneDeal0 commented Sep 29, 2024

BREAKING CHANGE:

subPropertiesDiff has been removed from the getObjectDiff output. There is now a single recursive diff key for more simplicity.

The new model is:

/** recursive diff in case of subproperties */
export type Diff = {
  property: string;
  previousValue: unknown;
  currentValue: unknown;
  status: OBJECT_STATUS;
  diff?: Diff[];
};

export type ObjectDiff = {
  type: "object";
  status: OBJECT_STATUS;
  diff: Diff[];
};

The types have also been improved.

@DoneDeal0 DoneDeal0 self-assigned this Sep 29, 2024
@DoneDeal0 DoneDeal0 force-pushed the simplify-output branch 3 times, most recently from 248da00 to 72ce750 Compare September 29, 2024 12:00
BREAKING CHANGE: subPropertiesDiff and subDiff have been removed from the object diff, there is now a single diff recursive key for more simplicity
@DoneDeal0 DoneDeal0 marked this pull request as ready for review September 29, 2024 12:01
@DoneDeal0 DoneDeal0 changed the title feat: simplify output, clean readme feat: simplify output + improve types + clean readme Sep 29, 2024
@DoneDeal0 DoneDeal0 merged commit c6a186e into master Sep 29, 2024
1 check passed
@DoneDeal0 DoneDeal0 deleted the simplify-output branch September 29, 2024 12:08
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant