Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SA1649 code fix does not remove files from linked projects #1693

Open
sharwell opened this issue Oct 26, 2015 · 3 comments · May be fixed by #3862
Open

SA1649 code fix does not remove files from linked projects #1693

sharwell opened this issue Oct 26, 2015 · 3 comments · May be fixed by #3862
Assignees
@vweijsters
Labels
blocked bug

Comments

@sharwell
Copy link
Member

When renaming a source file A.cs → B.cs, the code fix for SA1649 properly updates each project which previously included A.cs to now include B.cs. However, it only removes A.cs from the project which was the context for the rename operation.

During the rename, the original file needs to be removed from all projects which contained it.
@vweijsters
Copy link
Contributor

Grabbing this

@vweijsters vweijsters mentioned this issue Oct 30, 2015
Closed
@sharwell
Copy link
Member Author

Blocked on dotnet/roslyn#6261.

@bjornhellander
Copy link
Contributor

The root cause simply seems to be a missing call to RemoveDocument here:
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/StyleCop.Analyzers/StyleCop.Analyzers.CodeFixes/DocumentationRules/SA1649CodeFixProvider.cs#L66-L71

bjornhellander added a commit to bjornhellander/StyleCopAnalyzers that referenced this issue Jul 2, 2024
@bjornhellander
Update SA1649CodeFixProvider to first remove the file in other projec…
282c5e1 
…ts which reference the same file before adding them there (to not end up with two identical files in those projects) and also to re-add files with correct path (to not get a copy where there was a link before)

DotNetAnalyzers#1693 DotNetAnalyzers#3866
@bjornhellander bjornhellander linked a pull request Jul 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vweijsters vweijsters

Labels
blocked bug
Projects
None yet
Milestone
No milestone
3 participants
@sharwell @bjornhellander @vweijsters