Skip to content

Commit cafde38

Browse files
GrabYourPitchforksjkotas
authored andcommitted
Remove old method names from Rune (dotnet/coreclr#23938)
* Remove old method names from Rune, reenable suppressed tests * Revert re-enablement of failing ArraySegment tests Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
1 parent 539c2ee commit cafde38

File tree

1 file changed

+0
-60
lines changed
  • src/System.Private.CoreLib/shared/System/Text

1 file changed

+0
-60
lines changed

src/System.Private.CoreLib/shared/System/Text/Rune.cs

Lines changed: 0 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -663,46 +663,6 @@ public static OperationStatus DecodeLastFromUtf8(ReadOnlySpan<byte> source, out
663663
}
664664
}
665665

666-
public static OperationStatus DecodeUtf16(ReadOnlySpan<char> utf16Source, out Rune result, out int charsConsumed)
667-
{
668-
// [TODO] This method was renamed to DecodeFromUtf16. We'll leave this copy of
669-
// the method here temporarily so that we don't break corefx consumers
670-
// while the rename takes place.
671-
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319
672-
673-
return DecodeFromUtf16(utf16Source, out result, out charsConsumed);
674-
}
675-
676-
public static OperationStatus DecodeUtf16FromEnd(ReadOnlySpan<char> utf16Source, out Rune result, out int charsConsumed)
677-
{
678-
// [TODO] This method was renamed to DecodeLastFromUtf16. We'll leave this copy of
679-
// the method here temporarily so that we don't break corefx consumers
680-
// while the rename takes place.
681-
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319
682-
683-
return DecodeLastFromUtf16(utf16Source, out result, out charsConsumed);
684-
}
685-
686-
public static OperationStatus DecodeUtf8(ReadOnlySpan<byte> utf8Source, out Rune result, out int bytesConsumed)
687-
{
688-
// [TODO] This method was renamed to DecodeFromUtf8. We'll leave this copy of
689-
// the method here temporarily so that we don't break corefx consumers
690-
// while the rename takes place.
691-
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319
692-
693-
return DecodeFromUtf8(utf8Source, out result, out bytesConsumed);
694-
}
695-
696-
public static OperationStatus DecodeUtf8FromEnd(ReadOnlySpan<byte> utf8Source, out Rune result, out int bytesConsumed)
697-
{
698-
// [TODO] This method was renamed to DecodeLastFromUtf8. We'll leave this copy of
699-
// the method here temporarily so that we don't break corefx consumers
700-
// while the rename takes place.
701-
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319
702-
703-
return DecodeLastFromUtf8(utf8Source, out result, out bytesConsumed);
704-
}
705-
706666
/// <summary>
707667
/// Encodes this <see cref="Rune"/> to a UTF-16 destination buffer.
708668
/// </summary>
@@ -985,16 +945,6 @@ public bool TryEncodeToUtf16(Span<char> destination, out int charsWritten)
985945
return false;
986946
}
987947

988-
public bool TryEncode(Span<char> destination, out int charsWritten)
989-
{
990-
// [TODO] This method was renamed to TryEncodeToUtf16. We'll leave this copy of
991-
// the method here temporarily so that we don't break corefx consumers
992-
// while the rename takes place.
993-
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319
994-
995-
return TryEncodeToUtf16(destination, out charsWritten);
996-
}
997-
998948
/// <summary>
999949
/// Encodes this <see cref="Rune"/> to a destination buffer as UTF-8 bytes.
1000950
/// </summary>
@@ -1063,16 +1013,6 @@ public bool TryEncodeToUtf8(Span<byte> destination, out int bytesWritten)
10631013
return false;
10641014
}
10651015

1066-
public bool TryEncodeToUtf8Bytes(Span<byte> destination, out int bytesWritten)
1067-
{
1068-
// [TODO] This method was renamed to TryEncodeToUtf8. We'll leave this copy of
1069-
// the method here temporarily so that we don't break corefx consumers
1070-
// while the rename takes place.
1071-
// Tracking issue: https://github.com/dotnet/coreclr/issues/23319
1072-
1073-
return TryEncodeToUtf8(destination, out bytesWritten);
1074-
}
1075-
10761016
/// <summary>
10771017
/// Attempts to get the <see cref="Rune"/> which begins at index <paramref name="index"/> in
10781018
/// string <paramref name="input"/>.

0 commit comments

Comments
 (0)