You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior
I expect the rules to be picked up and used.
It seems that the ro-main.json file is parsed after the actual subtitle is done?
Version:
# subclean --version
You are using subclean@1.8.0
Additional context
It seems that any "custom" language file rules are loaded after the subtitle is processed. If I move the rules to main.json, they are applied properly:
{
_: [],
debug: true,
lang: 'ro',
w: true,
i: 'Stargate SG-1 - S10E20 - Unending Bluray-1080p.ro.srt'
}
[debug] readFile: [utf-8] /root/subclean/filters/main.json
[debug] readFile: [utf-8] /root/subclean/filters/users.json
[Info] Language codes matched: .ro.srt,ro
[Filter] [app] Added 141 items from filter 'main'
[Filter] [app] Added 54 items from filter 'users'
[Info] Encoding: utf-8, Language: romanian
[debug] readFile: [utf-8] Stargate SG-1 - S10E20 - Unending Bluray-1080p.ro.srt
[Info] Attempting to load language filters: ro
[debug] readFile: [utf-8] /root/subclean/filters/ro-main.json
[Match] Advertising found in node 44 (subtitrari-noi.ro)
[Line] <i>ReSincronizare: Agentuoo7</i>
<font color="#8000ff">Subtitrări-Noi Team - www.subtitrari-noi.ro</font>
[Match] Advertising found in node 479 (subtitrari-noi.ro)
[Line] <i>ReSincronizare: Agentuoo7</i>
<font color="#8000ff">Subtitrări-Noi Team - www.subtitrari-noi.ro</font>
[Info] Removed empty nodes: 44, 479
[Info] Save file: Stargate SG-1 - S10E20 - Unending Bluray-1080p.ro.srt
[Done] Removed 2 node(s) and wrote to Stargate SG-1 - S10E20 - Unending Bluray-1080p.ro.srt
[Debug] 93,600 checks
[Debug] 195 filters applied
[Debug] 480 text nodes
[Info] Save file: /root/subclean/logs/latest.txt
[Filter] [app] Added 3 items from filter 'ro-main.json'
The text was updated successfully, but these errors were encountered:
Thank you for reporting this error. Could you please upload one of the subtitles that did not work.
At a glance it seems to be an error with another package that parses the file but I will take a look when I can.
I'm very sick at the moment so I can't provide a fix right away. Sorry for the inconvenience.
Describe the bug
I'm trying to add Romanian to the supported languages, but I can't seem to be able to get it working.
To Reproduce
Steps to reproduce the behavior:
ro-main.json
in~/subclean/filters/ro-main.json
.ro.srt
has the strings:--debug
:Expected behavior
I expect the rules to be picked up and used.
It seems that the
ro-main.json
file is parsed after the actual subtitle is done?Version:
Additional context
It seems that any "custom" language file rules are loaded after the subtitle is processed. If I move the rules to
main.json
, they are applied properly:The text was updated successfully, but these errors were encountered: