Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search/Filter UI Improvements #1385

Open
ivaniesta14 opened this issue Nov 27, 2024 · 0 comments
Open

Search/Filter UI Improvements #1385

ivaniesta14 opened this issue Nov 27, 2024 · 0 comments
Labels

Comments

@ivaniesta14
Copy link
Contributor

I find the current implementation of the Search/Filter UI a bit clunky for the following reasons:

  • It covers content: words at the top of the word list, and half of the selection word's UI.
  • The popup animates in, which takes time before I can start filtering.
  • There's no incremental search, meaning I need to confirm my query before the list is filtered.
  • The popup closes itself upon confirming a query, which, together with the two points above, means a typo in the query takes a non-insignificant amount of time to correct.
  • Confirming the query triggers a full UI reload of the whole window, even when the query has not changed. For some reason, this makes the PolyGlot window stop being maximized if it was previously.
  • The search/filter button disappears or takes a while to display the popup after changing scenes (eg. to the word generator section). Might be caused by SrcLexicon's ctor.

A way the first four points could be addressed is by having two textboxes (one for local words and another for constructed ones) that filter the word list accordingly as text is typed into them. (Compare with chrome/firefox's Ctrl+F searchbox)

As for the fifth point, it might be worth looking into ScrLexicon.runFilter as there seem to be repeated calls to ScrLexicon.populateLexicon that may cause further issues.

In case it matters, I'm running the 2023-02-26 beta version under windows 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants