Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Manual tilt applies too late #611

Open
Hoshikara opened this issue Jul 26, 2022 · 4 comments
Open

[Bug] Manual tilt applies too late #611

Hoshikara opened this issue Jul 26, 2022 · 4 comments
Assignees
Labels

Comments

@Hoshikara
Copy link

Describe the bug
Manual tilt applies too late

Expected behavior
Expected behavior is the left, 0.5.0
Incorrect behavior (manual tilt is apparent by the camera jerk) is the right, latest develop commit
https://streamable.com/0tjor3

Screenshots
Manual tilt is set to 0 within 2 beats of both singular slams to override default pre-tilt behavior
Tilt set to NORMAL for the first red/right laser
tilt

Desktop (please complete the following information):

  • OS: Windows 11
  • GPU: Intel UHD 630
  • CPU: i9 10850k
  • Version: 0.5.0 and 2022-06-28_d748c188

Additional context
All offsets set to 0 for both recordings
Chart used

@Hoshikara
Copy link
Author

Hoshikara commented Jul 26, 2022

I built commits f55c8ab and 4062a25 (#515), the issue exists in the latter but not the former @123jimin

@123jimin
Copy link

123jimin commented Jul 26, 2022

I'll have a look at it. 😓

Edit: it might takes a few days for me to work on this

@123jimin
Copy link

Found the issue: BeatmapPlayback::CheckIfManualTiltInstant (and the Beatmap function it calls) seems to be implemented incorrectly.
I'll fix it during this weekend...

@123jimin
Copy link

bad news: I tried to fix the function but even after I fixed it the problem still persists. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants