Update tests and solution.

Author: DriesSchaumont

pandas/core/common.py

@@ -478,14 +478,15 @@ def get_rename_function(mapper):
     if isinstance(mapper, (abc.Mapping, ABCSeries)):
 
         def f(x):
-            if x in mapper:
-                return mapper[x]
-            else:
+            if isinstance(x, bool):
+                for map_key, repl in mapper.items():
+                    if id(map_key) == id(x):
+                        return repl
                 return x
+            return mapper.get(x, x)
 
     else:
         f = mapper
-
     return f
 
 

pandas/tests/frame/methods/test_rename.py

@@ -403,3 +403,13 @@ def test_rename_with_duplicate_columns(self):
             ],
         ).set_index(["STK_ID", "RPT_Date"], drop=False)
         tm.assert_frame_equal(result, expected)
+
+
+def test_rename_dict_wrong_matches():
+    # GH4980
+    df = DataFrame(np.arange(15).reshape(5, 3), columns=[False, True, 2])
+    mapper = {0: "foo", 1: "bar", 2: "bah"}
+    res = df.rename(columns=mapper)
+    expected = df.copy()
+    expected.columns = [False, True, "bah"]
+    tm.assert_frame_equal(res, expected)

pandas/tests/series/methods/test_rename.py

@@ -101,3 +101,13 @@ def test_rename_callable(self):
         tm.assert_series_equal(result, expected)
 
         assert result.name == expected.name
+
+
+def test_rename_dict_wrong_matches():
+    # GH4980
+    ser = Series(range(3), index=Index([False, True, 2]))
+    mapper = {0: "foo", 1: "bar", 2: "bah"}
+    res = ser.rename(mapper)
+    expected = ser.copy()
+    expected.index = Index([False, True, "bah"])
+    tm.assert_series_equal(res, expected)