Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why the auth plugin allow empty password permitted #101

Closed
haowanxing opened this issue May 28, 2021 · 1 comment · Fixed by #102
Closed

Why the auth plugin allow empty password permitted #101

haowanxing opened this issue May 28, 2021 · 1 comment · Fixed by #102

Comments

@haowanxing
Copy link

Here the func Auth.validate
if hashedPassword == "" || password == "" { return true, nil }
dose it a bad logic?
@DrmagicE
Copy link
Owner

You are right. That was a careless mistake. I will fix it later.

@DrmagicE DrmagicE mentioned this issue May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix authentication error DrmagicE/gmqtt
2 participants
@haowanxing @DrmagicE