Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Feature: Add IdentityProviderProperty to set IdentityProvider properties #1501

Closed
pampua84 opened this issue Dec 3, 2024 · 5 comments
Closed
Assignees

Comments

@pampua84
Copy link

pampua84 commented Dec 3, 2024

Hi,
is there any plan to add an IdentityProviderProperty class, similar to the ones for Client, ApiResource, etc.?

This table could be very useful for setting additional properties on IdentityProvider, example such as enabling the LoginHint, or determining which flow to execute for a given provider based on its properties, and so on.

Thanks

@RolandGuijt
Copy link

Do you mean the Dictionary<string, string> Properties property?
If so it is already present.

@pampua84
Copy link
Author

pampua84 commented Dec 4, 2024

However, the basic properties of this type of object must still be predefined (see OidcProvider or SamlProvider properties). It would be convenient to have an additional table to simply add other properties or attributes to the IdentityProvider, without having to deserialize a JSON (dictionary), which in the case of SamlProvider is also quite substantial.

@RolandGuijt RolandGuijt self-assigned this Dec 5, 2024
@jpda
Copy link

jpda commented Dec 5, 2024

We've added our own in a derived DbContext but it would be great to have this out-of-the-box. Extending EF is a huge pain.

@damianh
Copy link
Member

damianh commented Dec 16, 2024

Schema changes, especially for a library, are particularly problematic. Every change requires a migration of some sort and is considered a breaking change. This is both a blessing and a curse. The former because it's been stable over the years and the latter because we haven't been able to make improvements without needing to bump the major version every time.

In the future we'll be re-evaluating our approach to our storage interfaces and implementations thereof.

@RolandGuijt
Copy link

Closing this issue for now in light of Damian's comment, but if you'd like to add anything, please do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants