Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentityModel.Tests need to also be run on net48 (windows). #59

Open
damianh opened this issue Nov 19, 2024 · 4 comments · May be fixed by #60
Open

IdentityModel.Tests need to also be run on net48 (windows). #59

damianh opened this issue Nov 19, 2024 · 4 comments · May be fixed by #60
Assignees
@damianh
Labels
area/identity-model Issues related to Identity Model
Milestone
im-future

Comments

@damianh
Copy link
Member

damianh commented Nov 19, 2024

Used to be the case in prior repository, needed to run tests to validate netstandard2.0 target.
@damianh damianh added area/access-token-management Issues related to Access Token Management priority/2 High labels Nov 19, 2024
@damianh damianh self-assigned this Nov 19, 2024
@damianh damianh added this to the atm-3.1 milestone Dec 2, 2024
@damianh damianh removed the priority/2 High label Dec 2, 2024
@josephdecock josephdecock linked a pull request Dec 16, 2024 that will close this issue
Seperate build job from pack job and add matrix support #60
Open
@josephdecock josephdecock removed a link to a pull request Dec 16, 2024
Seperate build job from pack job and add matrix support #60
Open
@josephdecock
Copy link
Member

I think maybe this is referring to the wrong package, or else we can just close it. We historically ran access token management's tests on windows mac and linux, but we don't have (and never had) a .NET Framework build of access token management.

@josephdecock
Copy link
Member

Is #60 related to this?

@josephdecock josephdecock linked a pull request Dec 16, 2024 that will close this issue
Seperate build job from pack job and add matrix support #60
Open
@leastprivilege
Copy link
Member

DATM targets ASP.NET (Core) - no netfx.

@damianh damianh added area/identity-model Issues related to Identity Model and removed area/access-token-management Issues related to Access Token Management labels Dec 17, 2024
@damianh damianh modified the milestones: atm-3.1.0, im-future Dec 17, 2024
@damianh damianh changed the title AccessTokenManagement.Tests need to also be run on net48 (windows). IdentityModel.Tests need to also be run on net48 (windows). Dec 17, 2024
@damianh
Copy link
Member Author

damianh commented Dec 17, 2024

My bad, I meant Duende.IdentityModel. Title updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damianh damianh

Labels
area/identity-model Issues related to Identity Model
Projects
None yet
Milestone
im-future
Development

Successfully merging a pull request may close this issue.

Seperate build job from pack job and add matrix support DuendeSoftware/foss
3 participants
@damianh @josephdecock @leastprivilege