Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider OTel Metrics #1200

Closed
leastprivilege opened this issue Mar 1, 2023 · 9 comments · Fixed by #1456
Closed

Consider OTel Metrics #1200

leastprivilege opened this issue Mar 1, 2023 · 9 comments · Fixed by #1456
Assignees
Milestone

Comments

@leastprivilege
Copy link
Member

https://opentelemetry.io/docs/reference/specification/metrics/

@leastprivilege leastprivilege added this to the 7.x milestone Mar 1, 2023
@leastprivilege leastprivilege self-assigned this Mar 1, 2023
@josephdecock
Copy link
Member

Is this a duplicate of #1199?

@leastprivilege
Copy link
Member Author

yes. thanks!

@leastprivilege
Copy link
Member Author

leastprivilege commented Jul 6, 2023

YouTube video: https://youtu.be/c4AJlZeX2fE

MS implementation: dotnet/aspnetcore#46834

@leastprivilege leastprivilege linked a pull request Jul 6, 2023 that will close this issue
@brockallen
Copy link
Member

Perhaps relevant? dotnet/core#8437 (comment)

@leastprivilege
Copy link
Member Author

Recap:

  • We pick a first round of useful metrics and define them in IdentityServer
  • We discuss separate metrics vs metrics with tags/properties
  • We emit the metrics from within the core engine
  • Maybe we need to have metrics in the QS UI (e.g. login success/failure)

@AndersAbel sounds good?

@AndersAbel
Copy link
Member

@leastprivilege Yes, looks good. First step will be to create the list of useful metrics and discuss.

@mrjamiebowman
Copy link

Just wanted to reach out and tell you guys that you're doing a wonderful job with this.

Open Telemetry is the future, we have been experimenting with this and Identity Server 6 and it has made troubleshooting performance issues significantly easier.

I saw the incoming pull request for adding Meters/Metric Counters around events like token creation, failures. That is amazing! We love that you all are doing this because we want to be able to create alerts and rules if those metrics drop below a threshold or go over. This is wonderful and I look forward to seeing this in IDS 7.

@AndersAbel
Copy link
Member

@mrjamiebowman Thank you for your kind words. If you have any suggestions for events that are important to consider for the first round of metrics, please feel free to share them here. Any other opinions on how to design the metrics setup based on your experience are useful too.

@AndersAbel
Copy link
Member

@mrjamiebowman There's now a pull request for the first set of counters/metrics. If you have any feedback, please feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants