-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow aborting macros Including homing moves - "not quite an emergency, but STOP" #765
Labels
enhancement
Additional functionality, performance or other feature request
Milestone
Comments
Also this should allow running conditional gcode to be cancelled. |
It should already be possible to cancel M116 waits using M108, although the documentation for M108 doesn't mention it. I will update the documentation. |
25 tasks
T3P3
changed the title
Allow cancellation of M116 waits and macros
Allow cancellation of macros Including homing moves
Feb 7, 2024
T3P3
changed the title
Allow cancellation of macros Including homing moves
Allow aborting macros Including homing moves - "not quite an emergency, but STOP"
Feb 7, 2024
Aborting a homing move is effectively a "not quite an emergency" stop. Cancelling M116 heating wait is M108 - check this works correctly Aborting macros, whatever a macro is addressing is now an unknown state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Allow cancellation of the following:
These need to be able to be cancelled from the same input as they came from.
It is accepted that this could leave the machine in an unknown state, so for example, cancelling homing would leave the axes that were marked as unhomed at the start of the homing macro, unhomed.
would this supersede M108?
Ideally these work arounds could be replaced by a gcode that cancelled the wait/macro.
Consideration should be made for what happens after the cancel, my initial thoughts:
There is a work around which replaces M116 with a while loop and check if a global variable changes state in order to cancel the wait for temp however it requires the cancel to com from a different input channel from where the wait was called. (This work around is also possible to use to cancel out of bed probing)
The text was updated successfully, but these errors were encountered: