Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#378): Curation #452

Merged
merged 31 commits into from
Oct 15, 2023
Merged

feat(#378): Curation #452

merged 31 commits into from
Oct 15, 2023

Conversation

tholulomo
Copy link
Contributor

@tholulomo tholulomo commented Oct 9, 2023 •
edited
Loading

This pull request addresses several key aspects, including the submission of curation forms, enhancements to the backend curation logic to accommodate form submission and editing, XML editing and submission via the user interface, partial entry of FEA fields into the JSON object, as well as refactoring of the XMLFinder and XMLViewer components, among other improvements.

Added an updated master template spreadsheet file for xml curation

closes #378

@tholulomo
feat(#378): Adding css styles for xml curation form
8434cc1
@tholulomo
feat(#378): Adding the curation stepper router address to the curatio…
e5ab8c5 
…n form link on drawer
@tholulomo
feat(#378): Updating xml finder and xmlviewer graphql queries to retu…
899e342 
…rn user details
@tholulomo
feat(#378): Linter fixers
ff7c030
@tholulomo
feat(#378): Enabling curation stepper form in curation link page
93f1ebf
@tholulomo
feat(#378): Updating the template link download for error cases
bd4d868
@tholulomo
feat(#378): Adding logic to enable both submitter and admin to edit n…
3176bc2 
…ewly curated xml
@tholulomo
feat(#378): Adding curation form and curation form edit to app router
c594f2d
@tholulomo
feat(#378): Adding curation form component and logic
7b3f1d5
@tholulomo
feat(#378): Curation form unit tests
c8fd15d
@tholulomo
feat(#378): Adding DMA datafile to BE constant
8ae3012
@tholulomo
feat(#378): Xlsx json object refactoring for FEA Data
aa934b5
@tholulomo
feat(#378): jwt service middleware refactoring
e81660d
@tholulomo
feat(#378): Capping file upload size
97a4a7a
@tholulomo
feat(#378): Refactoring fileManager utils
559daf9
@tholulomo
feat(#378): Updating curation api response for swagger
839ca55
@tholulomo
feat(#378): Updating graphql xmlfinder and viewer unit tests
4a91746
@tholulomo
feat(#378): Expand list of acceptable files for BE and linter fixes
2e8aa7f
@tholulomo
feat(#378): Adding a generate csv file function
79786b9
@tholulomo
feat(#378): Fix failing unit test in admin controller
8272ff6
@tholulomo
feat(#378): Updating curation route on BE
9315f84
@tholulomo
feat(#378): Updating mongoDB curation pipeline to return users
5969d83
@tholulomo
feat(#378): Updating curation validation middleware
9f73469
@tholulomo
feat(#378): Updating fileController logic to handle internal controll…
da9a0e4 
…er to controller calls
@tholulomo
feat(#378): Updating BE curation controller logic to handle form cura…
e81d0a2 
…tion and edit
@tholulomo
feat(#378): Updating curation object regex to match both csv and tsv …
a44ee0f 
…files
@tholulomo
feat(#378): Merge upstream changes
352c8eb
aswallace
aswallace approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@aswallace aswallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only other comments that some fields that should be multiples weren't showing up as multiples and that we should consider splitting the properties step
Also need to clear snackbar so it doesn't maintain infinitely

app/src/components/explorer/MultipleInputComponent.vue Outdated Show resolved Hide resolved
app/src/store/modules/explorer/curation/actions.js Outdated Show resolved Hide resolved
app/src/store/modules/explorer/curation/actions.js Outdated Show resolved Hide resolved
app/src/store/modules/explorer/curation/actions.js Outdated Show resolved Hide resolved
app/src/pages/explorer/curate/form/CurationForm.vue Outdated Show resolved Hide resolved
app/tests/unit/components/explorer/InputComponent.spec.js Show resolved Hide resolved
app/tests/unit/components/explorer/InputComponent.spec.js Show resolved Hide resolved
app/tests/unit/pages/explorer/CurationForm.spec.js Outdated Show resolved Hide resolved
app/tests/unit/pages/explorer/CurationForm.spec.js Outdated Show resolved Hide resolved
resfulservice/spec/controllers/curationController.spec.js Outdated Show resolved Hide resolved
@tholulomo tholulomo merged commit a56e16c into develop Oct 15, 2023
6 checks passed
@tholulomo tholulomo deleted the #378_Curation_Form branch October 15, 2023 02:24
aswallace added a commit that referenced this pull request Jan 22, 2024
@aswallace
feat(#452): add ROR api and track curating user for SDD datasets
b6f63f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswallace aswallace aswallace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Xlsx curation stepper form - UI
2 participants
@tholulomo @aswallace