Feature: Add clear image cache from memory and disk #425

guhungry · 2019-03-09T02:30:15Z

I have a use case that need to clear image cache after user logout
I tested it on both android and iOS

codecov · 2019-03-09T02:31:34Z

Codecov Report

Merging #425 into master will decrease coverage by 7.75%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   94.11%   86.36%   -7.76%     
==========================================
  Files           1        1              
  Lines          17       22       +5     
==========================================
+ Hits           16       19       +3     
- Misses          1        3       +2

Impacted Files	Coverage Δ
src/index.js	`86.36% <60%> (-7.76%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89c0e2e...2b79960. Read the comment docs.

codecov · 2019-03-09T02:31:34Z

Codecov Report

Merging #425 (4ab44eb) into master (325d77f) will decrease coverage by 8.28%.
The diff coverage is 50.00%.

❗ Current head 4ab44eb differs from pull request most recent head 590b036. Consider uploading reports for the commit 590b036 to get more accurate results

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
- Coverage   95.23%   86.95%   -8.29%     
==========================================
  Files           1        1              
  Lines          21       23       +2     
  Branches        2        0       -2     
==========================================
  Hits           20       20              
- Misses          1        3       +2

Impacted Files	Coverage Δ
src/index.js	`86.95% <50.00%> (ø)`
src/index.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fc024b...590b036. Read the comment docs.

macdevnet · 2019-03-18T16:09:53Z

This is a pretty useful addition. Any thoughts on if it is going to be accepted?

Palid · 2019-04-04T08:28:39Z

+1 on this, I'd love this addition to the library.

brunocrpontes · 2019-09-19T01:27:18Z

Any expectations about when it will be merged?

barrylachapelle · 2019-11-28T20:38:42Z

+1 would love this for development/testing

ios/FastImage/FFFastImageViewManager.m

ntelkedzhiev · 2020-04-07T14:10:59Z

Any updates on this?

lx3133584 · 2020-04-11T09:50:53Z

This is a pretty useful addition

hanayashiki · 2020-06-18T19:47:22Z

Why wasn't this merged?

guhungry · 2020-06-20T05:35:16Z

@DylanVann I rebase the code and use promise api as you suggest please review it.

guhungry · 2020-06-20T11:49:44Z

Working example

Android

iOS

1) Load image & kill app & open app, clear mem, clear disk 2) kill app && open app

tgensol · 2020-10-27T18:16:05Z

Any updates on this one ?

zyestin · 2021-03-02T03:50:38Z

Nice, Tks~
But, the version we're using is above 8.3.2, part of directory structure is as blow. So the file should make change also need to update. Will you update ?

node_modules/react-native-fast-image/android
node_modules/react-native-fast-image/dist
node_modules/react-native-fast-image/dist/index.cjs.js
node_modules/react-native-fast-image/dist/index.d.ts
node_modules/react-native-fast-image/dist/index.d.ts.map
node_modules/react-native-fast-image/dist/index.js
node_modules/react-native-fast-image/dist/index.js.flow
node_modules/react-native-fast-image/dist/index.test.d.ts
node_modules/react-native-fast-image/dist/index.test.d.ts.map
node_modules/react-native-fast-image/ios

trickeyd · 2021-08-12T14:47:57Z

So what is the situation with this PR?

It seems that with the sheer quantity of issues concerning memory management with this lib, this is a quick win for those attempting to manage it manually, no?

mhdSid · 2021-08-26T10:08:42Z

I'll try to create a PR which contains the newly updated docs

trickeyd · 2021-08-26T10:40:44Z

@mhdSid Done it here
#818

Sorry didn't make into a PR earlier as I've been testing it

DylanVann

Looks great!

# [8.4.0](v8.3.7...v8.4.0) (2021-09-15) ### Bug Fixes * export FastImageStaticProperties ([#822](#822)) ([d69f692](d69f692)) * update dv-scripts ([61fab12](61fab12)) * update dv-scripts ([3c6d0f4](3c6d0f4)) ### Features * add clear image cache from memory and disk ([#425](#425)) ([818ed0c](818ed0c))

github-actions · 2021-09-15T09:05:09Z

🎉 This PR is included in version 8.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mhdSid · 2021-09-15T22:58:28Z

https://github.com/DylanVann/react-native-fast-image#static-methods

pranav-jft · 2022-05-18T13:25:12Z

https://github.com/DylanVann/react-native-fast-image#static-methods

Hello can anyone tell me how am I supposed to use it as simply calling FastImage.clearMemoryCache();
FastImage.clearDiskCache(); isn't showing any difference in xcode profiler

fukemy · 2022-11-08T07:23:39Z

love u all

fukemy · 2022-11-08T07:24:04Z

@pranav-jft, u can call this method everytime app open, in useEffect of App.js...

vineethvijayan314 · 2023-01-30T08:07:05Z

Is it possible to clear images with a TTL(Time to Live) like 10 days or something?

# [8.4.0](DylanVann/react-native-fast-image@v8.3.7...v8.4.0) (2021-09-15) ### Bug Fixes * export FastImageStaticProperties ([#822](DylanVann/react-native-fast-image#822)) ([d69f692](DylanVann/react-native-fast-image@d69f692)) * update dv-scripts ([61fab12](DylanVann/react-native-fast-image@61fab12)) * update dv-scripts ([3c6d0f4](DylanVann/react-native-fast-image@3c6d0f4)) ### Features * add clear image cache from memory and disk ([#425](DylanVann/react-native-fast-image#425)) ([818ed0c](DylanVann/react-native-fast-image@818ed0c))

# [8.4.0](DylanVann/react-native-fast-image@v8.3.7...v8.4.0) (2021-09-15) ### Bug Fixes * export FastImageStaticProperties ([DylanVann#822](DylanVann#822)) ([d69f692](DylanVann@d69f692)) * update dv-scripts ([61fab12](DylanVann@61fab12)) * update dv-scripts ([3c6d0f4](DylanVann@3c6d0f4)) ### Features * add clear image cache from memory and disk ([DylanVann#425](DylanVann#425)) ([818ed0c](DylanVann@818ed0c))

guhungry mentioned this pull request Mar 9, 2019

No way to clean cached images #197

Open

guhungry mentioned this pull request Mar 27, 2019

Feature/preload callbacks #437

Closed

guhungry force-pushed the feature_clear_cache_memory_and_disk branch from 2b79960 to 4ab44eb Compare May 9, 2019 03:50

diegolmello mentioned this pull request May 10, 2019

Pull to refresh on rooms list and room RocketChat/Rocket.Chat.ReactNative#884

Closed

luatnd added a commit to luatnd/react-native-fast-image that referenced this pull request Jul 18, 2019

Add caching management from DylanVann#425 pull request

de8463e

bpouzet mentioned this pull request Aug 21, 2019

add caching management #544

Open

DylanVann reviewed Mar 1, 2020

View reviewed changes

ios/FastImage/FFFastImageViewManager.m Outdated Show resolved Hide resolved

guhungry force-pushed the feature_clear_cache_memory_and_disk branch 3 times, most recently from e0f48c3 to 28d06a5 Compare June 20, 2020 05:27

guhungry force-pushed the feature_clear_cache_memory_and_disk branch 2 times, most recently from dfe9aa2 to ee3f590 Compare June 20, 2020 07:13

guhungry and others added 2 commits June 20, 2020 14:22

[Circle CI] Fix: Error due to @babel/compat-data force update to 7.10.3

432d01d

Feature: Add clear image cache from memory and disk

1912be0

guhungry force-pushed the feature_clear_cache_memory_and_disk branch from ee3f590 to 1912be0 Compare June 20, 2020 07:22

djorkaeffalexandre mentioned this pull request Jul 16, 2020

[IMPROVEMENT] Clear image cache when clear cache RocketChat/Rocket.Chat.ReactNative#2300

Merged

mezalejandro mentioned this pull request Aug 28, 2020

Taking too much memory, and app crashes #715

Open

dandre-hound mentioned this pull request Feb 1, 2021

ios memory issue #736

Open

trickeyd mentioned this pull request Aug 12, 2021

Memory issues when showing a ton of images. #195

Open

trickeyd mentioned this pull request Aug 26, 2021

reapplied clear image cache PR #818

Closed

alburdette619 mentioned this pull request Sep 7, 2021

EXC_BAD_ACCESS [FFFastImageView downloadImage:options:] #660

Open

Merge branch 'master' into feature_clear_cache_memory_and_disk

590b036

DylanVann approved these changes Sep 14, 2021

View reviewed changes

DylanVann merged commit 818ed0c into DylanVann:master Sep 14, 2021

github-actions bot added the released label Sep 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Add clear image cache from memory and disk #425

Feature: Add clear image cache from memory and disk #425

guhungry commented Mar 9, 2019

codecov bot commented Mar 9, 2019

codecov bot commented Mar 9, 2019 •

edited

Loading

macdevnet commented Mar 18, 2019

Palid commented Apr 4, 2019

brunocrpontes commented Sep 19, 2019

barrylachapelle commented Nov 28, 2019

ntelkedzhiev commented Apr 7, 2020

lx3133584 commented Apr 11, 2020

hanayashiki commented Jun 18, 2020

guhungry commented Jun 20, 2020

guhungry commented Jun 20, 2020

tgensol commented Oct 27, 2020

zyestin commented Mar 2, 2021

trickeyd commented Aug 12, 2021

mhdSid commented Aug 26, 2021

trickeyd commented Aug 26, 2021

DylanVann left a comment

github-actions bot commented Sep 15, 2021

mhdSid commented Sep 15, 2021

pranav-jft commented May 18, 2022

fukemy commented Nov 8, 2022

fukemy commented Nov 8, 2022

vineethvijayan314 commented Jan 30, 2023

Feature: Add clear image cache from memory and disk #425

Feature: Add clear image cache from memory and disk #425

Conversation

guhungry commented Mar 9, 2019

codecov bot commented Mar 9, 2019

Codecov Report

codecov bot commented Mar 9, 2019 • edited Loading

Codecov Report

macdevnet commented Mar 18, 2019

Palid commented Apr 4, 2019

brunocrpontes commented Sep 19, 2019

barrylachapelle commented Nov 28, 2019

ntelkedzhiev commented Apr 7, 2020

lx3133584 commented Apr 11, 2020

hanayashiki commented Jun 18, 2020

guhungry commented Jun 20, 2020

guhungry commented Jun 20, 2020

tgensol commented Oct 27, 2020

zyestin commented Mar 2, 2021

trickeyd commented Aug 12, 2021

mhdSid commented Aug 26, 2021

trickeyd commented Aug 26, 2021

DylanVann left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 15, 2021

mhdSid commented Sep 15, 2021

pranav-jft commented May 18, 2022

fukemy commented Nov 8, 2022

fukemy commented Nov 8, 2022

vineethvijayan314 commented Jan 30, 2023

codecov bot commented Mar 9, 2019 •

edited

Loading