Skip to content

Commit f62daf1

Browse files
Restore msgbox_mask package defaults (#2527)
Updates DR to [a15656a0c](36a6d23). Replaces the AUTOMATED_TESTING set in package builds by PR #2474 with the new DISABLE_ZLIB CMake option added by DynamoRIO/dynamorio#7030. This fixes a regression where msgbox_mask was set to 0 by default in packages, which caused many users to fail to obtain error information and has led to confusion with silent errors. Tested: Built https://github.com/DynamoRIO/drmemory/releases/tag/cronbuild-2.6.20005, unzipped it, and confirmed it pops up a message box by default on the machine where DynamoRIO/dynamorio#7024 is hit. Fixes DynamoRIO/dynamorio#7025
1 parent 384f6aa commit f62daf1

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

package.cmake

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# **********************************************************
2-
# Copyright (c) 2010-2022 Google, Inc. All rights reserved.
2+
# Copyright (c) 2010-2024 Google, Inc. All rights reserved.
33
# Copyright (c) 2009-2010 VMware, Inc. All rights reserved.
44
# **********************************************************
55

@@ -136,7 +136,7 @@ set(base_cache "
136136
UNIQUE_BUILD_NUMBER:STRING=${arg_ubuild}
137137
BUILD_TOOL_TESTS:BOOL=OFF
138138
BUILDING_PACKAGE:BOOL=ON
139-
AUTOMATED_TESTING:BOOL=ON
139+
DISABLE_ZLIB:BOOL=ON
140140
${sub_entry}
141141
${arg_cacheappend}
142142
${base_cache}

0 commit comments

Comments
 (0)