RtlpHeapFailureInfo thwarts leak reporting

[derekbruening]

From bruen...@google.com on February 11, 2011 16:12:48

tests/suppress.c deliberately calls HeapFree 2 words into an allocation to
test invalid heap argument reporting. that allocation is thus leaked.
however, on Vista and Win7, the leak is not reported (it is on xp).

I tracked it down to some RtlpHeapFailureInfo data structure:

Note: next higher malloc: 0x01319a78-0x01319a98
...
Error #15: INVALID HEAP ARGUMENT: RtlFreeHeap 0x01319a80
...
defined range 0x775d4000-0x775d7000
0x775d4278 points to chunk 0x01319a78-0x01319a98

0:001> ln 0x775d4278
(775d4268) ntdll!RtlpHeapFailureInfo+0x10 | (775d4320) ntdll!g_SxsTrackReleaseStacks

This complication would go away if we replaced instead of wrapped

Original issue: http://code.google.com/p/drmemory/issues/detail?id=292

[derekbruening]

From bruen...@google.com on March 16, 2011 07:55:46

Hopefully any such leak false negative will always be preceded by
unaddressable errors or heap routine failure warnings, and that once fixed
the leak will be reported

[derekbruening]

From derek.br...@gmail.com on March 16, 2011 09:09:52

This issue was closed by revision r229 .

Status: Fixed